KAFKA-19717: fix(connect/transforms): preserve fractional digits in InsertHeader literal values#22609
Open
wilmerdooley wants to merge 1 commit into
Open
KAFKA-19717: fix(connect/transforms): preserve fractional digits in InsertHeader literal values#22609wilmerdooley wants to merge 1 commit into
wilmerdooley wants to merge 1 commit into
Conversation
…s a number Signed-off-by: wilmerdooley <wilmerdooley1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
InsertHeaderSMT was dropping the fractional part of literal values when the parsed schema resolved to an integral type. For example, configuringvalue.literal: "2.0"produced a header with value2instead of2.0. Theconfiguremethod now detects this case and rewrites the schema and value toFLOAT32,FLOAT64, orDecimalso the original literal is preserved.The behavior change is localized to
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/InsertHeader.java. WhenValues.parseStringreturns an integral-typedSchemaAndValueand the raw configured string contains a decimal point, the literal is re-encoded usingBigDecimal, falling back toDecimalfor values outside the range offloat/double. All other inputs keep the previous behavior.Why
Testing
Added
InsertHeaderTest.insertionWithFloatHeader, which configures the SMT with the literal"2.0"and asserts that the resulting header carries aFLOAT32value of2.0fwhile preserving any pre-existing headers on the record. Existing tests continue to cover the integral and string literal paths, so non-numeric and integer literals are unchanged.Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.
JIRA: https://issues.apache.org/jira/browse/KAFKA-19717